docs(core): Add svelte docs recipe #18590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
force-pushed
the
docs/svelte-recipe-example
branch
from
f42d5e0
to
4e0a793
Compare
ndcunningham
force-pushed
the
docs/svelte-recipe-example
branch
from
4e0a793
to
1953571
Compare
isaacplmann
requested changes
Aug 14, 2023
docs/map.json
Outdated
| { | ||
| "name": "Add a Svelte Project", | ||
| "id": "add-svelte", | ||
| "description": "Add a Vue project to your repo", |
There was a problem hiding this comment.
Suggested change
| "description": "Add a Vue project to your repo", | |
| "description": "Add a Svelte project to your repo", |
| }); | ||
| ``` | ||
|
|
||
| {%callout type="Note"%} |
There was a problem hiding this comment.
Suggested change
| {%callout type="Note"%} | |
| {%callout type="Note" title="Why use the .mts file extension?" %} |
Comment on lines
166
to
198
| "build": { | ||
| "executor": "@nx/vite:build", | ||
| "outputs": ["{options.outputPath}"], | ||
| "defaultConfiguration": "production", | ||
| "options": { | ||
| "outputPath": "dist/acme" | ||
| }, | ||
| "configurations": { | ||
| "development": { | ||
| "mode": "development" | ||
| }, | ||
| "production": { | ||
| "mode": "production" | ||
| } | ||
| } | ||
| }, | ||
| "serve": { | ||
| "executor": "@nx/vite:dev-server", | ||
| "defaultConfiguration": "development", | ||
| "options": { | ||
| "buildTarget": "acme:build" | ||
| }, | ||
| "configurations": { | ||
| "development": { | ||
| "buildTarget": "acme:build:development", | ||
| "hmr": true | ||
| }, | ||
| "production": { | ||
| "buildTarget": "acme:build:production", | ||
| "hmr": false | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "build": { | |
| "executor": "@nx/vite:build", | |
| "outputs": ["{options.outputPath}"], | |
| "defaultConfiguration": "production", | |
| "options": { | |
| "outputPath": "dist/acme" | |
| }, | |
| "configurations": { | |
| "development": { | |
| "mode": "development" | |
| }, | |
| "production": { | |
| "mode": "production" | |
| } | |
| } | |
| }, | |
| "serve": { | |
| "executor": "@nx/vite:dev-server", | |
| "defaultConfiguration": "development", | |
| "options": { | |
| "buildTarget": "acme:build" | |
| }, | |
| "configurations": { | |
| "development": { | |
| "buildTarget": "acme:build:development", | |
| "hmr": true | |
| }, | |
| "production": { | |
| "buildTarget": "acme:build:production", | |
| "hmr": false | |
| } | |
| } | |
| }, | |
| { | |
| "targets": { | |
| "build": { | |
| "executor": "@nx/vite:build", | |
| "outputs": ["{options.outputPath}"], | |
| "defaultConfiguration": "production", | |
| "options": { | |
| "outputPath": "dist/acme" | |
| }, | |
| "configurations": { | |
| "development": { | |
| "mode": "development" | |
| }, | |
| "production": { | |
| "mode": "production" | |
| } | |
| } | |
| }, | |
| "serve": { | |
| "executor": "@nx/vite:dev-server", | |
| "defaultConfiguration": "development", | |
| "options": { | |
| "buildTarget": "acme:build" | |
| }, | |
| "configurations": { | |
| "development": { | |
| "buildTarget": "acme:build:development", | |
| "hmr": true | |
| }, | |
| "production": { | |
| "buildTarget": "acme:build:production", | |
| "hmr": false | |
| } | |
| } | |
| } | |
| } | |
| } |
|
|
||
| Navigate to `project.json` and update it with the following content: | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Suggested change
| ```json | |
| ```json {% fileName="/apps/svelteapp/project.json" %} |
| **Create a new Nx workspace** | ||
|
|
||
| ```shell | ||
| create-nx-workspace@latest acme --preset=ts-standalone --nx-cloud=true |
There was a problem hiding this comment.
Don't start with standalone. Start with integrated. The idea is that someone already has an Nx workspace and wants to add Svelte to it.
| ## Create the application | ||
|
|
||
| ```shell | ||
| touch index.html |
There was a problem hiding this comment.
Suggested change
| touch index.html | |
| touch apps/svelteapp/index.html |
| export { default as Counter } from './Counter.svelte'; | ||
| ``` | ||
|
|
||
| {% callout "Note" %} |
There was a problem hiding this comment.
Suggested change
| {% callout "Note" %} | |
| {% callout "Note" title="Remember the default keyword" %} |
ndcunningham
force-pushed
the
docs/svelte-recipe-example
branch
from
1953571
to
74c4dcd
Compare
isaacplmann
approved these changes
Aug 15, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Svelte documentation for Nx recipes
Preview